Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 829983003: Rename SkDrawPictureCallback to SkPicture::AbortCallback (Closed)

Created:
5 years, 11 months ago by robertphillips
Modified:
5 years, 11 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update to ToT #

Patch Set 3 : Add SK_API to SkPicture::AbortCallback #

Patch Set 4 : Readd deleted android gypi changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -44 lines) Patch
M gyp/skia_for_android_framework_defines.gypi View 2 3 1 chunk +1 line, -0 lines 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkDrawPictureCallback.h View 2 chunks +8 lines, -5 lines 0 comments Download
M include/core/SkPicture.h View 1 2 4 chunks +20 lines, -3 lines 0 comments Download
M src/core/SkPicture.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M src/core/SkPictureData.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkPicturePlayback.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkRecordDraw.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrRecordReplaceDraw.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/GrRecordReplaceDraw.cpp View 5 chunks +14 lines, -14 lines 0 comments Download
M tests/RecordDrawTest.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/RecordReplaceDrawTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
robertphillips
5 years, 11 months ago (2015-01-06 16:40:38 UTC) #2
reed1
lgtm
5 years, 11 months ago (2015-01-06 16:52:53 UTC) #3
robertphillips
This cannot be landed until https://codereview.chromium.org/806553004/ (Fix inclusion of SkDrawPictureCallback.h) lands.
5 years, 11 months ago (2015-01-06 17:41:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/829983003/1
5 years, 11 months ago (2015-01-06 20:12:51 UTC) #6
commit-bot: I haz the power
Failed to apply patch for gyp/skia_for_android_framework_defines.gypi: While running git apply --index -3 -p1; error: patch ...
5 years, 11 months ago (2015-01-06 20:12:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/829983003/20001
5 years, 11 months ago (2015-01-06 20:17:01 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/7ef197255deb4e2fa64c03c7130d56ddf164e83c
5 years, 11 months ago (2015-01-06 20:26:12 UTC) #11
reed2
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/824013004/ by reed@chromium.org. ...
5 years, 11 months ago (2015-01-07 00:14:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/829983003/60001
5 years, 11 months ago (2015-01-07 14:29:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/829983003/60001
5 years, 11 months ago (2015-01-07 14:44:25 UTC) #17
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 15:28:45 UTC) #18
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/783fe16b8ed1cd1cff34eacc33296874a32f293b

Powered by Google App Engine
This is Rietveld 408576698