Optimize is-check to instanceof when it eliminates an interceptor

pkg/compiler/lib/src/ssa/interceptor_simplifier.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 /**
  * This phase simplifies interceptors in multiple ways:
  *
  * 1) If the interceptor is for an object whose type is known, it
  * tries to use a constant interceptor instead.
  *
- * 2) It specializes interceptors based on the selectors it is being
- * called with.
+ * 2) Interceptors are specialized based on the selector it is used with.
  *
- * 3) If we know the object is not intercepted, we just use it
+ * 3) If we know the object is not intercepted, we just use the object
  * instead.
  *
- * 4) It replaces all interceptors that are used only once with
- * one-shot interceptors. It saves code size and makes the receiver of
- * an intercepted call a candidate for being generated at use site.
+ * 4) Single use interceptors at dynamic invoke sites are replaced with 'one
+ * shot interceptors' which are synthesized static helper functions that fetch
+ * the interceptor and then call the method.  This saves code size and makes the
+ * receiver of an intercepted call a candidate for being generated at use site.
+ *
+ * 5) Some HIs operations on a interceptor are replaced with a HIs version that

[floitsch, 2015/01/16 14:14:34]

on an interceptor

[sra1, 2015/01/20 20:07:27]

Done.

+ * uses 'instanceof' rather than testing a type flag.
  *
  */
 class SsaSimplifyInterceptors extends HBaseVisitor
     implements OptimizationPhase {
   final String name = "SsaSimplifyInterceptors";
   final ConstantSystem constantSystem;
   final Compiler compiler;
   final CodegenWorkItem work;
   HGraph graph;
 
@@ skipping 14 matching lines @@
       if (shouldRemove) {
         instruction.block.remove(instruction);
       }
       instruction = next;
     }
   }
 
   bool visitInstruction(HInstruction instruction) => false;
 
   bool visitInvoke(HInvoke invoke) {
+    // TODO(sra): The interceptor is visited first, so this only does something
+    // when the interceptor was not replaced for all uses.  I'm not sure we
+    // should substitute a constant interceptor if the interceptor is already
+    // available in a local variable.

[floitsch, 2015/01/16 14:14:34]

If it's already in a local, let's just use it.
But maybe there are good examples where a change would make sense...

[sra1, 2015/01/20 20:07:27]

I was able to contrive an example where this removed the last reference to an
interceptor so I will leave it in for now.

+
     if (!invoke.isInterceptedCall) return false;
     var interceptor = invoke.inputs[0];
     if (interceptor is! HInterceptor) return false;
     HInstruction constant = tryComputeConstantInterceptor(
         invoke.inputs[1], interceptor.interceptedClasses);
     if (constant != null) {
       invoke.changeUse(interceptor, constant);
     }
     return false;
   }
@@ skipping 167 matching lines @@
           // Use a most general interceptor for other instructions, example,
           // is-checks and escaping interceptors.
           interceptedClasses.addAll(backend.interceptedClasses);
           break;
         }
       }
     }
 
     HInstruction receiver = node.receiver;
 
+    // TODO(sra): We should consider all uses together and do edits here, rather
+    // than at the use node (e.g. visitInvoke).  That would achieve an accurate
+    // usedBy count for the one-shot interceptor logic.
+
     if (canUseSelfForInterceptor(receiver, interceptedClasses)) {
       return rewriteToUseSelfAsInterceptor(node, receiver);
     }
 
     // Try computing a constant interceptor.
     HInstruction constantInterceptor =
         tryComputeConstantInterceptor(receiver, interceptedClasses);
     if (constantInterceptor != null) {
       node.block.rewrite(node, constantInterceptor);
       return false;
     }
 
     node.interceptedClasses = interceptedClasses;
 
-    // Try creating a one-shot interceptor.
+    // Try creating a one-shot interceptor or optimized is-check
     if (compiler.hasIncrementalSupport) return false;
     if (node.usedBy.length != 1) return false;
-    if (node.usedBy[0] is !HInvokeDynamic) return false;
+    HInstruction user = node.usedBy.single;
 
-    HInvokeDynamic user = node.usedBy[0];
-
-    // If [node] was loop hoisted, we keep the interceptor.
+    // If the interceptor [node] was loop hoisted, we keep the interceptor.
     if (!user.hasSameLoopHeaderAs(node)) return false;
 
-    // Replace the user with a [HOneShotInterceptor].
-    HConstant nullConstant = graph.addConstantNull(compiler);
-    List<HInstruction> inputs = new List<HInstruction>.from(user.inputs);
-    inputs[0] = nullConstant;
-    HOneShotInterceptor interceptor = new HOneShotInterceptor(
-        user.selector, inputs, user.instructionType, node.interceptedClasses);
-    interceptor.sourcePosition = user.sourcePosition;
-    interceptor.sourceElement = user.sourceElement;
+    bool replaceUserWith(HInstruction replacement) {
+      HBasicBlock block = user.block;
+      block.addAfter(user, replacement);
+      block.rewrite(user, replacement);
+      block.remove(user);
+      return false;
+    }
 
-    HBasicBlock block = user.block;
-    block.addAfter(user, interceptor);
-    block.rewrite(user, interceptor);
-    block.remove(user);
-    return true;
+    if (user is HIs) {
+      if (node == user.interceptor) {
+        JavaScriptBackend backend = compiler.backend;
+        if (backend.mayGenerateInstanceofCheck(user.typeExpression)) {
+          HInstruction instanceofCheck = new HIs.instanceOf(
+              user.typeExpression, user.expression, user.instructionType);
+          instanceofCheck.sourcePosition = user.sourcePosition;
+          instanceofCheck.sourceElement = user.sourceElement;
+          return replaceUserWith(instanceofCheck);
+        }
+      }
+    } else if (user is HInvokeDynamic) {
+      if (node == user.inputs[0]) {
+        // Replace the user with a [HOneShotInterceptor].
+        HConstant nullConstant = graph.addConstantNull(compiler);
+        List<HInstruction> inputs = new List<HInstruction>.from(user.inputs);
+        inputs[0] = nullConstant;
+        HOneShotInterceptor oneShotInterceptor = new HOneShotInterceptor(
+            user.selector, inputs, user.instructionType, interceptedClasses);
+        oneShotInterceptor.sourcePosition = user.sourcePosition;
+        oneShotInterceptor.sourceElement = user.sourceElement;
+        return replaceUserWith(oneShotInterceptor);
+      }
+    }
+
+    return false;
   }
 
   bool rewriteToUseSelfAsInterceptor(HInterceptor node, HInstruction receiver) {
     for (HInstruction user in node.usedBy.toList()) {
       if (user is HIs) {
         user.changeUse(node, receiver);
       } else {
         // Use the potentially self-argument as new receiver. Note that the
         // self-argument could potentially have a tighter type than the
         // receiver which was the input to the interceptor.
@@ skipping 31 matching lines @@
       instruction = new HInvokeDynamicMethod(
           selector, inputs, node.instructionType, true);
     }
 
     HBasicBlock block = node.block;
     block.addAfter(node, instruction);
     block.rewrite(node, instruction);
     return true;
   }
 }