Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 829913005: MIPS: ES6 computed property names. (Closed)

Created:
5 years, 11 months ago by paul.l...
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: ES6 computed property names. Port: 74e38e34b3caecfb660c3ed1336a58c551215793 Original commit message: This adds support for computed property names, under the flag --harmony-computed-property-names, for both object literals and classes. This is a revert of the revert, 7d48fd9dc29c8f5d7c8b5215f9bd537cdd005eba. BUG=v8:3754 LOG=Y Committed: https://crrev.com/966dad071af11d08d175da07d9c5cc88d293554e Cr-Commit-Position: refs/heads/master@{#26088}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -16 lines) Patch
M src/mips/full-codegen-mips.cc View 5 chunks +69 lines, -8 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 5 chunks +69 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
paul.l...
PTAL.
5 years, 11 months ago (2015-01-16 01:33:56 UTC) #2
arv (Not doing code reviews)
LGTM
5 years, 11 months ago (2015-01-16 01:47:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/829913005/1
5 years, 11 months ago (2015-01-16 01:57:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 04:42:37 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 04:42:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/966dad071af11d08d175da07d9c5cc88d293554e
Cr-Commit-Position: refs/heads/master@{#26088}

Powered by Google App Engine
This is Rietveld 408576698