Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 829883002: ARIA role menuitemcheckbox, menuitemradio should have AXMenuItemMarkChar ✓. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_cocoa.mm
diff --git a/content/browser/accessibility/browser_accessibility_cocoa.mm b/content/browser/accessibility/browser_accessibility_cocoa.mm
index dc1c35fbad4b4c41242e3070a750aa89786beddf..5e5fcaaf1c9e6fef74e952864a6f0eac2ce4a0a8 100644
--- a/content/browser/accessibility/browser_accessibility_cocoa.mm
+++ b/content/browser/accessibility/browser_accessibility_cocoa.mm
@@ -115,6 +115,7 @@ NSDictionary* attributeToMethodNameMap = nil;
{ @"AXLoaded", @"loaded" },
{ @"AXLoadingProgress", @"loadingProgress" },
{ @"AXPlaceholder", @"placeholder" },
+ { @"AXMenuItemMarkChar", @"menuItemMarkChar"},
{ @"AXRequired", @"required" },
{ @"AXSortDirection", @"sortDirection" },
{ @"AXVisited", @"visited" },
@@ -494,6 +495,13 @@ NSDictionary* attributeToMethodNameMap = nil;
return @"";
}
+- (NSString*)menuItemMarkChar {
+ if (GetState(browserAccessibility_, ui::AX_STATE_CHECKED))
+ return @"\u2713";
+ else
+ return @"nil";
+}
+
- (NSNumber*)numberOfCharacters {
std::string value = browserAccessibility_->GetStringAttribute(
ui::AX_ATTR_VALUE);
@@ -1388,6 +1396,10 @@ NSDictionary* attributeToMethodNameMap = nil;
NSAccessibilitySelectedChildrenAttribute,
NSAccessibilityVisibleChildrenAttribute,
nil]];
+ } else if ([role isEqualToString:NSAccessibilityMenuItemRole]) {
+ [ret addObjectsFromArray:[NSArray arrayWithObjects:
+ @"AXMenuItemMarkChar",
+ nil]];
}
// Add the url attribute only if it has a valid url.

Powered by Google App Engine
This is Rietveld 408576698