Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 829883002: ARIA role menuitemcheckbox, menuitemradio should have AXMenuItemMarkChar ✓.

Created:
5 years, 11 months ago by shreeramk
Modified:
3 years, 9 months ago
Reviewers:
aboxhall
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ARIA role menuitemcheckbox, menuitemradio should have AXMenuItemMarkChar ✓. BUG=421341, 169578

Patch Set 1 #

Patch Set 2 #

Patch Set 3 : #

Patch Set 4 : rebasing #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M content/browser/accessibility/accessibility_tree_formatter_mac.mm View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 3 3 chunks +12 lines, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-menuitemcheckbox.html View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-menuitemcheckbox-expected-mac.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/accessibility/aria/aria-menuitemradio.html View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-menuitemradio-expected-mac.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
shreeramk
@Dominic & @aboxhall: I have submitted the required change. But its not working, could you ...
5 years, 11 months ago (2015-01-06 03:20:24 UTC) #2
dmazzoni
I don't see anything obviously wrong. What happens if you open Accessibility Inspector, does AXMenuItemMarkChar ...
5 years, 11 months ago (2015-01-06 07:09:56 UTC) #3
shreeramk
On 2015/01/06 07:09:56, dmazzoni wrote: > I don't see anything obviously wrong. > > What ...
5 years, 11 months ago (2015-01-06 07:30:12 UTC) #4
shreeramk
@Dominic: I am not able to verify this patch.
5 years, 10 months ago (2015-02-11 06:42:46 UTC) #5
shreeramk
5 years, 9 months ago (2015-03-19 09:22:26 UTC) #6 
On 2015/01/06 07:09:56, dmazzoni wrote:
> I don't see anything obviously wrong.
> 
> What happens if you open Accessibility Inspector, does AXMenuItemMarkChar show
> up correctly there? How does it compare to in Safari?

Accessibility inspector is not working on my mac system. It seems xCode is
corrupted.

But I checked in safari(mac) web inspector, following info is shown:

Role menuitemcheckbox
Parent #document
Checked yes

Safari doesn't show any info for AXMenuItemMarkChar.

Powered by Google App Engine
This is Rietveld 408576698