Issue 829853003: Fix some Windows compile issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 829853003: Fix some Windows compile issues. (Closed)

Created:
5 years, 11 months ago by dcheng

Modified:
5 years, 11 months ago

Reviewers:
jamesr

CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix some Windows compile issues. - MSVC complains if an unsigned int is cast to a size_t. - "and" is not a valid preprocessor logical operator. BUG=none R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3c29b4df040d0c3ab25012a03b989ab36d643beb

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	mojo/edk/system/core_test_base.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/system/core_test_base.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/system/multiprocess_message_pipe_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

dcheng

I guess this is the joy of never actually having compiled any of the test ...

5 years, 11 months ago (2014-12-30 00:17:00 UTC) #2

jamesr

This is because we don't build anything for windows in the mojo repo. lgtm

5 years, 11 months ago (2014-12-30 00:18:05 UTC) #3

jamesr

5 years, 11 months ago (2014-12-30 00:31:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3c29b4df040d0c3ab25012a03b989ab36d643beb (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages