Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: content/browser/vr/vr_device.h

Issue 829803003: Adding Chrome-side WebVR interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed tedchoc@'s feedback Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CONTENT_BROWSER_VR_VR_DEVICE_H
6 #define CONTENT_BROWSER_VR_VR_DEVICE_H
7
8 namespace blink {
9 struct WebHMDSensorState;
10 struct WebVRFieldOfView;
11 class WebVRDevice;
12 struct WebVRVector4;
13 }
14
15 namespace ui {
16 class BaseWindow;
17 }
18
19 namespace content {
20
21 class VRDeviceProvider;
22
23 class VRDevice {
24 public:
25 VRDevice(VRDeviceProvider* provider);
mdempsky 2015/05/11 19:25:01 Nit: Add "explicit".
26 virtual ~VRDevice();
27
28 VRDeviceProvider* provider() const { return provider_; }
29 unsigned int id() const { return id_; }
30
31 virtual void GetVRDevice(blink::WebVRDevice* device) = 0;
32 virtual void GetSensorState(blink::WebHMDSensorState* state) = 0;
33 virtual void ResetSensor() = 0;
34
35 private:
36 VRDeviceProvider* provider_;
37 unsigned int id_;
38
39 static unsigned int next_id_;
40 };
mdempsky 2015/05/11 19:25:01 Nit: DISALLOW_COPY_AND_ASSIGN.
bajones 2015/05/12 00:13:39 Can't DISALLOW_COPY_AND_ASSIGN on an abstract clas
mdempsky_google 2015/05/12 00:25:15 Can you elaborate? Abstract classes still have im
41
42 } // namespace content
43
44 #endif // CONTENT_BROWSER_VR_VR_DEVICE_H
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698