content/browser/vr/vr_device.cc - Issue 829803003: Adding Chrome-side WebVR interface

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/vr/vr_device.cc

Issue 829803003: Adding Chrome-side WebVR interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed tedchoc@'s feedback Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "content/browser/vr/vr_device.h"

	6 #include "content/browser/vr/vr_device_provider.h"

	7

	8 namespace content {

	9

	10 unsigned int VRDevice::next_id_ = 1;

	11

	12 VRDevice::VRDevice(VRDeviceProvider* provider)

	13 : provider_(provider)

	14 , id_(next_id_) {

	15 next_id_++;
	mdempsky 2015/05/11 19:25:01 Are VRDevices guaranteed to be created in a single Are VRDevices guaranteed to be created in a single thread? What happens if next_id_ wraps around? Is it possible for an attacker on the web to create and destroy 2^32 VRDevice objects so that IDs are reused? bajones 2015/05/12 00:13:39 Theoretically, I suppose if you opened a tab, quer Show quoted text On 2015/05/11 19:25:01, mdempsky wrote: > Are VRDevices guaranteed to be created in a single thread? > > What happens if next_id_ wraps around? Is it possible for an attacker on the > web to create and destroy 2^32 VRDevice objects so that IDs are reused? Theoretically, I suppose if you opened a tab, queried VR devices, closed the tab, and then repeated that a couple billion times, sure. I think at that point I'm happy to stop returning VR devices, though. I'll add some simple logic to handle/prevent the wraparound case.
	16 }

	17

	18 VRDevice::~VRDevice() {

	19 }

	20

	21 } // namespace content

OLD	NEW