Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Side by Side Diff: Source/modules/accessibility/AXRenderObject.cpp

Issue 829773002: ARIA role status should have a implicit aria-atomic value of true. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 1129 matching lines...) Expand 10 before | Expand all | Expand 10 after
1140 1140
1141 // Default aria-relevant = "additions text". 1141 // Default aria-relevant = "additions text".
1142 if (relevant.isEmpty()) 1142 if (relevant.isEmpty())
1143 return defaultLiveRegionRelevant; 1143 return defaultLiveRegionRelevant;
1144 1144
1145 return relevant; 1145 return relevant;
1146 } 1146 }
1147 1147
1148 bool AXRenderObject::liveRegionAtomic() const 1148 bool AXRenderObject::liveRegionAtomic() const
1149 { 1149 {
1150 // ARIA role status should have implicit aria-atomic value of true.
1151 if (getAttribute(aria_atomicAttr).isEmpty() && roleValue() == StatusRole)
1152 return true;
1150 return elementAttributeValue(aria_atomicAttr); 1153 return elementAttributeValue(aria_atomicAttr);
1151 } 1154 }
1152 1155
1153 bool AXRenderObject::liveRegionBusy() const 1156 bool AXRenderObject::liveRegionBusy() const
1154 { 1157 {
1155 return elementAttributeValue(aria_busyAttr); 1158 return elementAttributeValue(aria_busyAttr);
1156 } 1159 }
1157 1160
1158 // 1161 //
1159 // Accessibility Text. 1162 // Accessibility Text.
(...skipping 1248 matching lines...) Expand 10 before | Expand all | Expand 10 after
2408 if (label && label->renderer()) { 2411 if (label && label->renderer()) {
2409 LayoutRect labelRect = axObjectCache()->getOrCreate(label)->elementR ect(); 2412 LayoutRect labelRect = axObjectCache()->getOrCreate(label)->elementR ect();
2410 result.unite(labelRect); 2413 result.unite(labelRect);
2411 } 2414 }
2412 } 2415 }
2413 2416
2414 return result; 2417 return result;
2415 } 2418 }
2416 2419
2417 } // namespace blink 2420 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698