Issue 82973005: Callbacks to ContentVideoView should match the fullscreen player Id

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 82973005: Callbacks to ContentVideoView should match the fullscreen player Id (Closed)

Created:
7 years, 1 month ago by qinmin

Modified:
7 years ago

Reviewers:
michaelbai

CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Callbacks to ContentVideoView should match the fullscreen player Id Currently we always send callbacks to the contentVideoView if media event comes. However, if a page has multiple players, other players can mess up with the fullscreen player. TBR=michaelbai Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236965

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	content/browser/media/android/browser_media_player_manager.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/82973005/1

7 years, 1 month ago (2013-11-23 00:31:55 UTC) #2

Message was sent while issue was closed.

Change committed as 236965

Expand Messages | Collapse Messages