Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 82973004: retry r235823 with more lax unit test. (Closed)

Created:
7 years, 1 month ago by Evan Stade
Modified:
7 years ago
CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

retry r235823 with more lax unit test. Add a timezone utility file to base/. Currently there's just one function exported, which checks the system timezone and returns a 2-character ASCII country code for it. BUG=303368 R=isherman@chromium.org TBR=jshin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237117

Patch Set 1 #

Patch Set 2 : old patch #

Patch Set 3 : new patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+653 lines, -0 lines) Patch
M base/base.gyp View 1 2 chunks +3 lines, -0 lines 0 comments Download
A base/i18n/timezone.h View 2 1 chunk +21 lines, -0 lines 0 comments Download
A base/i18n/timezone.cc View 1 chunk +608 lines, -0 lines 0 comments Download
A base/i18n/timezone_unittest.cc View 2 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Stade
7 years, 1 month ago (2013-11-22 21:30:41 UTC) #1
Ilya Sherman
Where'd the .gyp changes go? It would be helpful if you could upload a patch ...
7 years, 1 month ago (2013-11-22 22:42:17 UTC) #2
Evan Stade
dunno where the gyp changes went. Fixed. Patchset 2 is the previous commit. Patchset 3 ...
7 years, 1 month ago (2013-11-22 23:06:09 UTC) #3
Ilya Sherman
Thanks, LGTM (though I'm not an owner).
7 years, 1 month ago (2013-11-22 23:12:22 UTC) #4
Evan Stade
7 years ago (2013-11-25 19:20:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r237117 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698