Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 829643003: Remove USE_ATHENA ifdefs from chrome/browser/chromeos/accessibility (Closed)

Created:
5 years, 11 months ago by pkotwicz
Modified:
5 years, 11 months ago
Reviewers:
oshima
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove USE_ATHENA ifdefs from chrome/browser/chromeos/accessibility BUG=448836 TEST=None Committed: https://crrev.com/04d5c89a1a72ee98c8e6a9aea710322e009cf3e1 Cr-Commit-Position: refs/heads/master@{#311579}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -75 lines) Patch
M chrome/browser/chromeos/accessibility/accessibility_manager.h View 5 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 23 chunks +9 lines, -63 lines 0 comments Download
M chrome/browser/chromeos/accessibility/magnification_manager.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pkotwicz
Oshima PTAL I also removed a few useless USE_ASH and OS_CHROMEOS ifdefs More CLs coming!
5 years, 11 months ago (2015-01-14 21:13:24 UTC) #2
oshima
lgtm
5 years, 11 months ago (2015-01-14 21:56:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/829643003/1
5 years, 11 months ago (2015-01-14 22:24:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 00:06:10 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 00:07:09 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/04d5c89a1a72ee98c8e6a9aea710322e009cf3e1
Cr-Commit-Position: refs/heads/master@{#311579}

Powered by Google App Engine
This is Rietveld 408576698