Base: Move platform_file.* to files/base_file.*

Base: Move platform_file.* to files/base_file.*

PlatformFile has grown beyond the initial expectations and it doesn't make
sense to continue supporting individual function wrappers instead of a
proper file class.

BUG=322664
TEST=base_unittests

[rvargas (doing something else), 2013-11-23 02:22:32]

Please take a look

[rvargas (doing something else), 2013-11-26 22:56:52]

On 2013/11/23 02:22:32, rvargas wrote:
> Please take a look

ping

[brettw, 2013-11-26 23:04:49]

Sorry I lost this!

Is there a reason this can't be called base::File instead? (Like "File" is
#defined on some system?)

https://codereview.chromium.org/82963004/diff/180001/base/files/base_file.h
File base/files/base_file.h (right):

https://codereview.chromium.org/82963004/diff/180001/base/files/base_file.h#n...
base/files/base_file.h:34: enum BaseFileFlags {
Can these be in the BaseFile class? If I was doing this from scratch, I'd use
names like BaseFile::FLAG_OPEN.

[rvargas (doing something else), 2013-11-26 23:45:53]

I don't know of a #define File, but there is the c FILE... I have a File class
inside the cache code and I think sometimes I have to use the full name
(disk_cache::File) where I shouldn't have to but it may be cargo cult.

I can go with File if you want me to. It's the same to me (and I like short
names). Just let me know which way to go.

https://codereview.chromium.org/82963004/diff/180001/base/files/base_file.h
File base/files/base_file.h (right):

https://codereview.chromium.org/82963004/diff/180001/base/files/base_file.h#n...
base/files/base_file.h:34: enum BaseFileFlags {
On 2013/11/26 23:04:49, brettw wrote:
> Can these be in the BaseFile class? If I was doing this from scratch, I'd use
> names like BaseFile::FLAG_OPEN.

Sure... I assume you are talking only about the enums.

[brettw, 2013-11-27 00:53:14]

I like base::File a lot better.

For the nesting, I was indeed talking about the enums. BaseFileInfo I could go
either way on (base::FileInfo or base::File::Info).

[rvargas (doing something else), 2013-11-28 02:08:28]

Moving this review to https://codereview.chromium.org/93513002/