extensions/common/update_manifest.cc - Issue 829583002: Validate hash_sha256 checksum on .crx update.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/update_manifest.cc

Issue 829583002: Validate hash_sha256 checksum on .crx update. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add histogram description. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/common/update_manifest.cc

diff --git a/extensions/common/update_manifest.cc b/extensions/common/update_manifest.cc

index 26d794f11f4ec9f25262169d98082473399ad41e..1446b955d8b6331882cf7e5441cf8241a327fade 100644

--- a/extensions/common/update_manifest.cc

+++ b/extensions/common/update_manifest.cc

@@ -189,7 +189,7 @@ static bool ParseSingleAppTag(xmlNode* app_node, xmlNs* xml_namespace,

// package_hash is optional. It is only required for blacklist. It is a

// sha256 hash of the package in hex format.

- result->package_hash = GetAttribute(updatecheck, "hash");

+ result->package_hash = GetAttribute(updatecheck, "hash_sha256");

int size = 0;

if (base::StringToInt(GetAttribute(updatecheck, "size"), &size)) {