chrome/browser/extensions/updater/extension_updater.h - Issue 829583002: Validate hash_sha256 checksum on .crx update.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/updater/extension_updater.h

Issue 829583002: Validate hash_sha256 checksum on .crx update. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add histogram description. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/updater/extension_updater.h

diff --git a/chrome/browser/extensions/updater/extension_updater.h b/chrome/browser/extensions/updater/extension_updater.h

index 7e09908cfa6bbdd6a47d02dbc5084066a1a654f1..4823089a40297aac7453cc24f35368d24cdbf768 100644

--- a/chrome/browser/extensions/updater/extension_updater.h

+++ b/chrome/browser/extensions/updater/extension_updater.h

@@ -141,12 +141,14 @@ class ExtensionUpdater : public ExtensionDownloaderDelegate,

FetchedCRXFile();

FetchedCRXFile(const std::string& id,

const base::FilePath& path,

+ const std::string& hash,

bool file_ownership_passed,

const std::set<int>& request_ids);

~FetchedCRXFile();

std::string extension_id;

base::FilePath path;

+ std::string hash;

bool file_ownership_passed;

std::set<int> request_ids;

};

@@ -200,6 +202,7 @@ class ExtensionUpdater : public ExtensionDownloaderDelegate,

const std::set<int>& request_ids) override;

void OnExtensionDownloadFinished(const std::string& id,

const base::FilePath& path,

+ const std::string& hash,

bool file_ownership_passed,

const GURL& download_url,

const std::string& version,