Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: extensions/common/update_manifest.cc

Issue 829583002: Validate hash_sha256 checksum on .crx update. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unittest build for windows. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/switches.cc ('k') | extensions/extensions.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/update_manifest.cc
diff --git a/extensions/common/update_manifest.cc b/extensions/common/update_manifest.cc
index 26d794f11f4ec9f25262169d98082473399ad41e..57162da71e7bc0d82a98040a4bc45ce9e4d0ffdf 100644
--- a/extensions/common/update_manifest.cc
+++ b/extensions/common/update_manifest.cc
@@ -187,9 +187,9 @@ static bool ParseSingleAppTag(xmlNode* app_node, xmlNs* xml_namespace,
}
}
- // package_hash is optional. It is only required for blacklist. It is a
- // sha256 hash of the package in hex format.
- result->package_hash = GetAttribute(updatecheck, "hash");
+ // package_hash is optional. It is a sha256 hash of the package in hex
+ // format.
+ result->package_hash = GetAttribute(updatecheck, "hash_sha256");
int size = 0;
if (base::StringToInt(GetAttribute(updatecheck, "size"), &size)) {
« no previous file with comments | « extensions/common/switches.cc ('k') | extensions/extensions.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698