extensions/browser/updater/extension_downloader_delegate.h - Issue 829583002: Validate hash_sha256 checksum on .crx update.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/updater/extension_downloader_delegate.h

Issue 829583002: Validate hash_sha256 checksum on .crx update. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unittest build for windows. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/updater/extension_downloader_delegate.h

diff --git a/extensions/browser/updater/extension_downloader_delegate.h b/extensions/browser/updater/extension_downloader_delegate.h

index aed6885c4bb873809b0623750cc4d14ff7f5e02d..2e5eaa59b70072800cde447cd87852175a980c40 100644

--- a/extensions/browser/updater/extension_downloader_delegate.h

+++ b/extensions/browser/updater/extension_downloader_delegate.h

@@ -9,6 +9,7 @@

#include <string>

#include "base/time/time.h"

+#include "extensions/browser/crx_file_info.h"

#include "extensions/browser/updater/manifest_fetch_data.h"

class GURL;

@@ -82,8 +83,7 @@ class ExtensionDownloaderDelegate {

// successfully downloaded to |path|. |ownership_passed| is true if delegate

// should get ownership of the file.

virtual void OnExtensionDownloadFinished(

- const std::string& id,

- const base::FilePath& path,

+ const CRXFileInfo& file,

bool file_ownership_passed,

const GURL& download_url,

const std::string& version,