Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3509)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/extensions/update_manifest_unittest.cc

Issue 829583002: Validate hash_sha256 checksum on .crx update. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unittest build for windows. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/updater/extension_updater_unittest.cc ('k') | extensions/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/update_manifest_unittest.cc
diff --git a/chrome/common/extensions/update_manifest_unittest.cc b/chrome/common/extensions/update_manifest_unittest.cc
index 36ea5d5b50753490f96aaa31accf70951948a35d..8915ab753972004199ecd540d4057f27237025ec 100644
--- a/chrome/common/extensions/update_manifest_unittest.cc
+++ b/chrome/common/extensions/update_manifest_unittest.cc
@@ -17,14 +17,14 @@ static const char kValidXml[] =
"</gupdate>";
static const char valid_xml_with_hash[] =
-"<?xml version='1.0' encoding='UTF-8'?>"
-"<gupdate xmlns='http://www.google.com/update2/response' protocol='2.0'>"
-" <app appid='12345'>"
-" <updatecheck codebase='http://example.com/extension_1.2.3.4.crx'"
-" version='1.2.3.4' prodversionmin='2.0.143.0' "
-" hash='1234'/>"
-" </app>"
-"</gupdate>";
+ "<?xml version='1.0' encoding='UTF-8'?>"
+ "<gupdate xmlns='http://www.google.com/update2/response' protocol='2.0'>"
+ " <app appid='12345'>"
+ " <updatecheck codebase='http://example.com/extension_1.2.3.4.crx'"
+ " version='1.2.3.4' prodversionmin='2.0.143.0' "
+ " hash_sha256='1234'/>"
+ " </app>"
+ "</gupdate>";
static const char kMissingAppId[] =
"<?xml version='1.0'?>"
« no previous file with comments | « chrome/browser/extensions/updater/extension_updater_unittest.cc ('k') | extensions/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698