Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2304)

Unified Diff: chrome/browser/extensions/updater/extension_updater.h

Issue 829583002: Validate hash_sha256 checksum on .crx update. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unittest build for windows. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/updater/extension_updater.h
diff --git a/chrome/browser/extensions/updater/extension_updater.h b/chrome/browser/extensions/updater/extension_updater.h
index 7e09908cfa6bbdd6a47d02dbc5084066a1a654f1..169534fc886686a37d138aad4bf08a9417039ebd 100644
--- a/chrome/browser/extensions/updater/extension_updater.h
+++ b/chrome/browser/extensions/updater/extension_updater.h
@@ -139,14 +139,12 @@ class ExtensionUpdater : public ExtensionDownloaderDelegate,
// but have not yet installed.
struct FetchedCRXFile {
FetchedCRXFile();
- FetchedCRXFile(const std::string& id,
- const base::FilePath& path,
+ FetchedCRXFile(const CRXFileInfo& file,
bool file_ownership_passed,
const std::set<int>& request_ids);
~FetchedCRXFile();
- std::string extension_id;
- base::FilePath path;
+ CRXFileInfo info;
bool file_ownership_passed;
std::set<int> request_ids;
};
@@ -198,8 +196,7 @@ class ExtensionUpdater : public ExtensionDownloaderDelegate,
Error error,
const PingResult& ping,
const std::set<int>& request_ids) override;
- void OnExtensionDownloadFinished(const std::string& id,
- const base::FilePath& path,
+ void OnExtensionDownloadFinished(const CRXFileInfo& file,
bool file_ownership_passed,
const GURL& download_url,
const std::string& version,
« no previous file with comments | « chrome/browser/extensions/test_extension_service.cc ('k') | chrome/browser/extensions/updater/extension_updater.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698