Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Unified Diff: chrome/browser/extensions/extension_service.h

Issue 829583002: Validate hash_sha256 checksum on .crx update. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unittest build for windows. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.h
diff --git a/chrome/browser/extensions/extension_service.h b/chrome/browser/extensions/extension_service.h
index b65a45fe2796ffbc6e61e280f36a4bcf5ae76bba..4b6005d3aec06e20e474de92eaf0ca3f49c4359b 100644
--- a/chrome/browser/extensions/extension_service.h
+++ b/chrome/browser/extensions/extension_service.h
@@ -21,6 +21,7 @@
#include "chrome/browser/extensions/pending_extension_manager.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
+#include "extensions/browser/crx_file_info.h"
#include "extensions/browser/external_provider_interface.h"
#include "extensions/browser/install_flag.h"
#include "extensions/browser/management_policy.h"
@@ -83,8 +84,7 @@ class ExtensionServiceInterface
// TODO(aa): This method can be removed. ExtensionUpdater could use
// CrxInstaller directly instead.
virtual bool UpdateExtension(
- const std::string& id,
- const base::FilePath& path,
+ const extensions::CRXFileInfo& file,
bool file_ownership_passed,
extensions::CrxInstaller** out_crx_installer) = 0;
@@ -207,8 +207,7 @@ class ExtensionService
bool include_disabled) const override;
const extensions::Extension* GetInstalledExtension(
const std::string& id) const override;
- bool UpdateExtension(const std::string& id,
- const base::FilePath& extension_path,
+ bool UpdateExtension(const extensions::CRXFileInfo& file,
bool file_ownership_passed,
extensions::CrxInstaller** out_crx_installer) override;
bool IsExtensionEnabled(const std::string& extension_id) const override;
« no previous file with comments | « chrome/browser/extensions/extension_gcm_app_handler_unittest.cc ('k') | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698