Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4061)

Unified Diff: chrome/browser/chromeos/extensions/external_cache_unittest.cc

Issue 829583002: Validate hash_sha256 checksum on .crx update. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unittest build for windows. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/extensions/external_cache.cc ('k') | chrome/browser/extensions/crx_installer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/extensions/external_cache_unittest.cc
diff --git a/chrome/browser/chromeos/extensions/external_cache_unittest.cc b/chrome/browser/chromeos/extensions/external_cache_unittest.cc
index e0c63155fdac8ab573c716eeb0a838c5cbb63099..df6baeb16b289d9961324822332dd7e327d883a7 100644
--- a/chrome/browser/chromeos/extensions/external_cache_unittest.cc
+++ b/chrome/browser/chromeos/extensions/external_cache_unittest.cc
@@ -205,13 +205,9 @@ TEST_F(ExternalCacheTest, Basic) {
base::FilePath temp_dir(CreateTempDir());
base::FilePath temp_file2 = temp_dir.Append("b.crx");
CreateFile(temp_file2);
- external_cache.OnExtensionDownloadFinished(kTestExtensionId2,
- temp_file2,
- true,
- GURL(),
- "2",
- extensions::ExtensionDownloaderDelegate::PingResult(),
- std::set<int>());
+ external_cache.OnExtensionDownloadFinished(
+ extensions::CRXFileInfo(kTestExtensionId2, temp_file2), true, GURL(), "2",
+ extensions::ExtensionDownloaderDelegate::PingResult(), std::set<int>());
WaitForCompletion();
EXPECT_EQ(provided_prefs()->size(), 3ul);
@@ -234,13 +230,9 @@ TEST_F(ExternalCacheTest, Basic) {
// Update not from Webstore.
base::FilePath temp_file4 = temp_dir.Append("d.crx");
CreateFile(temp_file4);
- external_cache.OnExtensionDownloadFinished(kTestExtensionId4,
- temp_file4,
- true,
- GURL(),
- "4",
- extensions::ExtensionDownloaderDelegate::PingResult(),
- std::set<int>());
+ external_cache.OnExtensionDownloadFinished(
+ extensions::CRXFileInfo(kTestExtensionId4, temp_file4), true, GURL(), "4",
+ extensions::ExtensionDownloaderDelegate::PingResult(), std::set<int>());
WaitForCompletion();
EXPECT_EQ(provided_prefs()->size(), 4ul);
« no previous file with comments | « chrome/browser/chromeos/extensions/external_cache.cc ('k') | chrome/browser/extensions/crx_installer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698