Validate hash_sha256 checksum on .crx update.

extensions/browser/crx_file_info.h

Index: extensions/browser/crx_file_info.h
diff --git a/extensions/browser/crx_file_info.h b/extensions/browser/crx_file_info.h
new file mode 100644
index 0000000000000000000000000000000000000000..e85992b83805517c05fd1dfedccd3c641f889138
--- /dev/null
+++ b/extensions/browser/crx_file_info.h
@@ -0,0 +1,34 @@
+// Copyright (c) 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef EXTENSIONS_BROWSER_CRX_FILE_INFO_H_
+#define EXTENSIONS_BROWSER_CRX_FILE_INFO_H_
+
+#include <string>
+
+#include "base/files/file_path.h"
+
+namespace extensions {
+
+// CRXFileInfo holds general information about a cached CRX file
+struct CRXFileInfo {
+  CRXFileInfo();
+  CRXFileInfo(const std::string& extension_id,
+              const base::FilePath& path,
+              const std::string& hash);
+  CRXFileInfo(const std::string& extension_id, const base::FilePath& path);
+  explicit CRXFileInfo(const base::FilePath& path);
+
+  bool operator==(const CRXFileInfo& that) const;
+
+  // The only mandatory field is the file path, whereas extension_id and hash
+  // are only being checked if those are non-empty.
+  std::string extension_id;
+  base::FilePath path;
+  std::string hash;

[asargent_no_longer_on_chrome, 2015/02/03 19:26:33]

I still think it would be better to rename


extension_id -> expected_extension_id
hash -> expected_hash

to avoid the possibility that consumers of this class in other unrelated code
will get confused and rely on the id/hash properties as representing "correct"
information that has already been verified with the contents of the file at
|path| and can be relied on for some security sensitive operation. 

+};
+
+}  // namespace extensions
+
+#endif  // EXTENSIONS_BROWSER_CRX_FILE_H_