chrome/browser/apps/ephemeral_app_browsertest.cc - Issue 829583002: Validate hash_sha256 checksum on .crx update.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/ephemeral_app_browsertest.cc

Issue 829583002: Validate hash_sha256 checksum on .crx update. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix histogram value. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/apps/ephemeral_app_browsertest.cc

diff --git a/chrome/browser/apps/ephemeral_app_browsertest.cc b/chrome/browser/apps/ephemeral_app_browsertest.cc

index 53c29911c1ad569161b6fdefd943a41c7dca4209..d28dd321f855a3ea41a7f7a3c912ac7e7eb3f765 100644

--- a/chrome/browser/apps/ephemeral_app_browsertest.cc

+++ b/chrome/browser/apps/ephemeral_app_browsertest.cc

@@ -273,8 +273,8 @@ const Extension* EphemeralAppTestBase::UpdateEphemeralApp(

content::Source<extensions::CrxInstaller>(crx_installer));

ExtensionService* service =

ExtensionSystem::Get(profile())->extension_service();

- EXPECT_TRUE(service->UpdateExtension(app_id, app_v2_path, true,

- &crx_installer));

+ EXPECT_TRUE(service->UpdateExtension(

+ extensions::CRXFileInfo(app_id, app_v2_path), true, &crx_installer));

windowed_observer.Wait();

return ExtensionRegistry::Get(profile())