Validate hash_sha256 checksum on .crx update.

chrome/browser/extensions/updater/extension_updater.h

Index: chrome/browser/extensions/updater/extension_updater.h
diff --git a/chrome/browser/extensions/updater/extension_updater.h b/chrome/browser/extensions/updater/extension_updater.h
index 7e09908cfa6bbdd6a47d02dbc5084066a1a654f1..1d6e0890c070d6542899d42231cbc0b84d1a04ec 100644
--- a/chrome/browser/extensions/updater/extension_updater.h
+++ b/chrome/browser/extensions/updater/extension_updater.h
@@ -137,16 +137,13 @@ class ExtensionUpdater : public ExtensionDownloaderDelegate,
 
   // FetchedCRXFile holds information about a CRX file we fetched to disk,
   // but have not yet installed.
-  struct FetchedCRXFile {
+  struct FetchedCRXFile : public CRXFileInfo {

[asargent_no_longer_on_chrome, 2015/02/03 00:42:55]

I think we'd be better off using composition (have a FetchedCRXFile member
variable) instead of inheritance here.

See style guide entry which encourages this:

http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Inheritance

     FetchedCRXFile();
-    FetchedCRXFile(const std::string& id,
-                   const base::FilePath& path,
+    FetchedCRXFile(const CRXFileInfo& file,
                    bool file_ownership_passed,
                    const std::set<int>& request_ids);
     ~FetchedCRXFile();
 
-    std::string extension_id;
-    base::FilePath path;
     bool file_ownership_passed;
     std::set<int> request_ids;
   };
@@ -198,8 +195,7 @@ class ExtensionUpdater : public ExtensionDownloaderDelegate,
                                  Error error,
                                  const PingResult& ping,
                                  const std::set<int>& request_ids) override;
-  void OnExtensionDownloadFinished(const std::string& id,
-                                   const base::FilePath& path,
+  void OnExtensionDownloadFinished(const CRXFileInfo& file,
                                    bool file_ownership_passed,
                                    const GURL& download_url,
                                    const std::string& version,