Validate hash_sha256 checksum on .crx update.

chrome/browser/extensions/updater/extension_updater.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/updater/extension_updater.h"
 
 #include <algorithm>
 #include <set>
 #include <vector>
 
@@ skipping 171 matching lines @@
 }  // namespace
 
 namespace extensions {
 
 ExtensionUpdater::CheckParams::CheckParams()
     : install_immediately(false) {}
 
 ExtensionUpdater::CheckParams::~CheckParams() {}
 
 ExtensionUpdater::FetchedCRXFile::FetchedCRXFile(
-    const std::string& i,
-    const base::FilePath& p,
+    const CRXFileInfo& file,
     bool file_ownership_passed,
     const std::set<int>& request_ids)
-    : extension_id(i),
-      path(p),
+    : info(file),
       file_ownership_passed(file_ownership_passed),
-      request_ids(request_ids) {}
+      request_ids(request_ids) {
+}
 
 ExtensionUpdater::FetchedCRXFile::FetchedCRXFile()
-    : path(), file_ownership_passed(true) {}
+    : info(), file_ownership_passed(true) {

[asargent_no_longer_on_chrome, 2015/02/03 19:26:33]

do you need to explicitly call the default constructor here? 

+}
 
 ExtensionUpdater::FetchedCRXFile::~FetchedCRXFile() {}
 
 ExtensionUpdater::InProgressCheck::InProgressCheck()
     : install_immediately(false) {}
 
 ExtensionUpdater::InProgressCheck::~InProgressCheck() {}
 
 struct ExtensionUpdater::ThrottleInfo {
   ThrottleInfo()
@@ skipping 371 matching lines @@
 
   // This method is called if no updates were found. However a previous update
   // check might have queued an update for this extension already. If a
   // current update check has |install_immediately| set the previously
   // queued update should be installed now.
   if (install_immediately && service_->GetPendingExtensionUpdate(id))
     service_->FinishDelayedInstallation(id);
 }
 
 void ExtensionUpdater::OnExtensionDownloadFinished(
-    const std::string& id,
-    const base::FilePath& path,
+    const CRXFileInfo& file,
     bool file_ownership_passed,
     const GURL& download_url,
     const std::string& version,
     const PingResult& ping,
     const std::set<int>& request_ids) {
   DCHECK(alive_);
-  UpdatePingData(id, ping);
+  UpdatePingData(file.extension_id, ping);
 
-  VLOG(2) << download_url << " written to " << path.value();
+  VLOG(2) << download_url << " written to " << file.path.value();
 
-  FetchedCRXFile fetched(id, path, file_ownership_passed, request_ids);
+  FetchedCRXFile fetched(file, file_ownership_passed, request_ids);
   fetched_crx_files_.push(fetched);
 
   // MaybeInstallCRXFile() removes extensions from |in_progress_ids_| after
   // starting the crx installer.
   MaybeInstallCRXFile();
 }
 
 bool ExtensionUpdater::GetPingDataForExtension(
     const std::string& id,
     ManifestFetchData::PingData* ping_data) {
@@ skipping 58 matching lines @@
 
 void ExtensionUpdater::MaybeInstallCRXFile() {
   if (crx_install_is_running_ || fetched_crx_files_.empty())
     return;
 
   std::set<int> request_ids;
 
   while (!fetched_crx_files_.empty() && !crx_install_is_running_) {
     const FetchedCRXFile& crx_file = fetched_crx_files_.top();
 
-    VLOG(2) << "updating " << crx_file.extension_id
-            << " with " << crx_file.path.value();
+    VLOG(2) << "updating " << crx_file.info.extension_id
+            << " with " << crx_file.info.path.value();
 
     // The ExtensionService is now responsible for cleaning up the temp file
-    // at |crx_file.path|.
+    // at |crx_file.info.path|.
     CrxInstaller* installer = NULL;
-    if (service_->UpdateExtension(crx_file.extension_id,
-                                  crx_file.path,
+    if (service_->UpdateExtension(crx_file.info,
                                   crx_file.file_ownership_passed,
                                   &installer)) {
       crx_install_is_running_ = true;
       current_crx_file_ = crx_file;
 
       for (std::set<int>::const_iterator it = crx_file.request_ids.begin();
           it != crx_file.request_ids.end(); ++it) {
         InProgressCheck& request = requests_in_progress_[*it];
         if (request.install_immediately) {
           installer->set_install_immediately(true);
           break;
         }
       }
 
       // Source parameter ensures that we only see the completion event for the
       // the installer we started.
       registrar_.Add(this,
                      extensions::NOTIFICATION_CRX_INSTALLER_DONE,
                      content::Source<CrxInstaller>(installer));
     } else {
       for (std::set<int>::const_iterator it = crx_file.request_ids.begin();
            it != crx_file.request_ids.end(); ++it) {
         InProgressCheck& request = requests_in_progress_[*it];
-        request.in_progress_ids_.remove(crx_file.extension_id);
+        request.in_progress_ids_.remove(crx_file.info.extension_id);
       }
       request_ids.insert(crx_file.request_ids.begin(),
                          crx_file.request_ids.end());
     }
     fetched_crx_files_.pop();
   }
 
   for (std::set<int>::const_iterator it = request_ids.begin();
        it != request_ids.end(); ++it) {
     NotifyIfFinished(*it);
   }
 }
 
 void ExtensionUpdater::Observe(int type,
                                const content::NotificationSource& source,
                                const content::NotificationDetails& details) {
   DCHECK_EQ(type, extensions::NOTIFICATION_CRX_INSTALLER_DONE);
 
   registrar_.Remove(this, extensions::NOTIFICATION_CRX_INSTALLER_DONE, source);
   crx_install_is_running_ = false;
 
   const FetchedCRXFile& crx_file = current_crx_file_;
   for (std::set<int>::const_iterator it = crx_file.request_ids.begin();
       it != crx_file.request_ids.end(); ++it) {
     InProgressCheck& request = requests_in_progress_[*it];
-    request.in_progress_ids_.remove(crx_file.extension_id);
+    request.in_progress_ids_.remove(crx_file.info.extension_id);
     NotifyIfFinished(*it);
   }
 
   // If any files are available to update, start one.
   MaybeInstallCRXFile();
 }
 
 void ExtensionUpdater::OnExtensionWillBeInstalled(
     content::BrowserContext* browser_context,
     const Extension* extension,
@@ skipping 15 matching lines @@
   const InProgressCheck& request = requests_in_progress_[request_id];
   if (request.in_progress_ids_.empty()) {
     VLOG(2) << "Finished update check " << request_id;
     if (!request.callback.is_null())
       request.callback.Run();
     requests_in_progress_.erase(request_id);
   }
 }
 
 }  // namespace extensions