Validate hash_sha256 checksum on .crx update.

chrome/browser/extensions/updater/extension_updater.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/updater/extension_updater.h"
 
 #include <algorithm>
 #include <set>
 #include <vector>
 
@@ skipping 171 matching lines @@
 }  // namespace
 
 namespace extensions {
 
 ExtensionUpdater::CheckParams::CheckParams()
     : install_immediately(false) {}
 
 ExtensionUpdater::CheckParams::~CheckParams() {}
 
 ExtensionUpdater::FetchedCRXFile::FetchedCRXFile(
-    const std::string& i,
-    const base::FilePath& p,
+    const CRXFileInfo& file,
     bool file_ownership_passed,
     const std::set<int>& request_ids)
-    : extension_id(i),
-      path(p),
+    : CRXFileInfo(file),

[asargent_no_longer_on_chrome, 2015/02/03 00:42:55]

As FYI, if we were to continue inheritance instead of composition (I don't think
we should), relying on the constructor-provided default constructor here would
be outlawed by the style guide:

http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Copyable_Mova...

"Due to the risk of slicing, avoid providing an assignment operator or public
copy/move constructor for a class that's intended to be derived from (and avoid
deriving from a class with such members). If your base class needs to be
copyable, provide a public virtual Clone() method, and a protected copy
constructor that derived classes can use to implement it. "

       file_ownership_passed(file_ownership_passed),
-      request_ids(request_ids) {}
+      request_ids(request_ids) {
+}
 
 ExtensionUpdater::FetchedCRXFile::FetchedCRXFile()
-    : path(), file_ownership_passed(true) {}
+    : CRXFileInfo(), file_ownership_passed(true) {
+}
 
 ExtensionUpdater::FetchedCRXFile::~FetchedCRXFile() {}
 
 ExtensionUpdater::InProgressCheck::InProgressCheck()
     : install_immediately(false) {}
 
 ExtensionUpdater::InProgressCheck::~InProgressCheck() {}
 
 struct ExtensionUpdater::ThrottleInfo {
   ThrottleInfo()
@@ skipping 371 matching lines @@
 
   // This method is called if no updates were found. However a previous update
   // check might have queued an update for this extension already. If a
   // current update check has |install_immediately| set the previously
   // queued update should be installed now.
   if (install_immediately && service_->GetPendingExtensionUpdate(id))
     service_->FinishDelayedInstallation(id);
 }
 
 void ExtensionUpdater::OnExtensionDownloadFinished(
-    const std::string& id,
-    const base::FilePath& path,
+    const CRXFileInfo& file,
     bool file_ownership_passed,
     const GURL& download_url,
     const std::string& version,
     const PingResult& ping,
     const std::set<int>& request_ids) {
   DCHECK(alive_);
-  UpdatePingData(id, ping);
+  UpdatePingData(file.extension_id, ping);
 
-  VLOG(2) << download_url << " written to " << path.value();
+  VLOG(2) << download_url << " written to " << file.path.value();
 
-  FetchedCRXFile fetched(id, path, file_ownership_passed, request_ids);
+  FetchedCRXFile fetched(file, file_ownership_passed, request_ids);
   fetched_crx_files_.push(fetched);
 
   // MaybeInstallCRXFile() removes extensions from |in_progress_ids_| after
   // starting the crx installer.
   MaybeInstallCRXFile();
 }
 
 bool ExtensionUpdater::GetPingDataForExtension(
     const std::string& id,
     ManifestFetchData::PingData* ping_data) {
@@ skipping 64 matching lines @@
 
   while (!fetched_crx_files_.empty() && !crx_install_is_running_) {
     const FetchedCRXFile& crx_file = fetched_crx_files_.top();
 
     VLOG(2) << "updating " << crx_file.extension_id
             << " with " << crx_file.path.value();
 
     // The ExtensionService is now responsible for cleaning up the temp file
     // at |crx_file.path|.
     CrxInstaller* installer = NULL;
-    if (service_->UpdateExtension(crx_file.extension_id,
-                                  crx_file.path,
-                                  crx_file.file_ownership_passed,
+    if (service_->UpdateExtension(crx_file, crx_file.file_ownership_passed,
                                   &installer)) {
       crx_install_is_running_ = true;
       current_crx_file_ = crx_file;
 
       for (std::set<int>::const_iterator it = crx_file.request_ids.begin();
           it != crx_file.request_ids.end(); ++it) {
         InProgressCheck& request = requests_in_progress_[*it];
         if (request.install_immediately) {
           installer->set_install_immediately(true);
           break;
@@ skipping 64 matching lines @@
   const InProgressCheck& request = requests_in_progress_[request_id];
   if (request.in_progress_ids_.empty()) {
     VLOG(2) << "Finished update check " << request_id;
     if (!request.callback.is_null())
       request.callback.Run();
     requests_in_progress_.erase(request_id);
   }
 }
 
 }  // namespace extensions