Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 829503002: Oilpan: fix build after r187699. (Closed)

Created:
5 years, 12 months ago by sof
Modified:
5 years, 12 months ago
Reviewers:
haraken, oilpan-reviews
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix build after r187699. TBR=oilpan-reviews,haraken BUG=443585 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187701

Patch Set 1 #

Patch Set 2 : Add missing WorkerInspectorController tracing #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M Source/core/inspector/AsyncCallStackTracker.h View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/core/inspector/AsyncCallStackTracker.cpp View 2 chunks +6 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/V8AsyncCallTracker.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/V8AsyncCallTracker.cpp View 1 chunk +1 line, -0 lines 2 comments Download
M Source/core/inspector/WorkerInspectorController.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
sof
Please take a look.
5 years, 12 months ago (2014-12-25 21:20:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/829503002/20001
5 years, 12 months ago (2014-12-25 21:21:30 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=187701
5 years, 12 months ago (2014-12-25 21:21:58 UTC) #4
haraken
LGTM https://codereview.chromium.org/829503002/diff/20001/Source/core/inspector/V8AsyncCallTracker.cpp File Source/core/inspector/V8AsyncCallTracker.cpp (right): https://codereview.chromium.org/829503002/diff/20001/Source/core/inspector/V8AsyncCallTracker.cpp#newcode37 Source/core/inspector/V8AsyncCallTracker.cpp:37: m_v8AsyncCallChains.dispose(); Not related to this CL, it looks ...
5 years, 12 months ago (2014-12-25 23:55:09 UTC) #5
sof
https://codereview.chromium.org/829503002/diff/20001/Source/core/inspector/V8AsyncCallTracker.cpp File Source/core/inspector/V8AsyncCallTracker.cpp (right): https://codereview.chromium.org/829503002/diff/20001/Source/core/inspector/V8AsyncCallTracker.cpp#newcode37 Source/core/inspector/V8AsyncCallTracker.cpp:37: m_v8AsyncCallChains.dispose(); On 2014/12/25 23:55:09, haraken wrote: > > Not ...
5 years, 12 months ago (2014-12-26 07:19:25 UTC) #6
sof
5 years, 12 months ago (2014-12-26 11:57:21 UTC) #7
Message was sent while issue was closed. 
On 2014/12/26 07:19:25, sof wrote:
>
https://codereview.chromium.org/829503002/diff/20001/Source/core/inspector/V8...
> File Source/core/inspector/V8AsyncCallTracker.cpp (right):
> 
>
https://codereview.chromium.org/829503002/diff/20001/Source/core/inspector/V8...
> Source/core/inspector/V8AsyncCallTracker.cpp:37:
m_v8AsyncCallChains.dispose();
> On 2014/12/25 23:55:09, haraken wrote:
> > 
> > Not related to this CL, it looks unsafe to touch m_v8AsyncCallChains in
> > V8ContextAsyncCallChains's destructor.
> 
> Yes, there needs to be a dispose()/reset() call from InspectorDebuggerAgent to
> clear this out (via V8AsyncCallTracker) instead. Which was pointed out on the
> CL, I believe.

https://codereview.chromium.org/818673004/ adds that dispose step.

Powered by Google App Engine
This is Rietveld 408576698