Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issue 829393005: Don't match empty style rules. (Closed)

Created:
5 years, 11 months ago by rune
Modified:
5 years, 11 months ago
Reviewers:
esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't match empty style rules. If a style rule has no declarations, skip selector matching unless we are matching for the inspector which expects empty rules to be included. The render tree dump for the first-letter-first-line-hover.html test did include a [color=#008000] for the first-letter renderer with this change. Most likely because this change avoids a hover recalc since not trying to match p:hover causes the hover flag not to be set on P. And that the render tree is different after doing a recalc on the first-letter, for some reason. Instead of rebasing the result, I made it a ref-test. R=esprehn@chromium.org BUG=448610 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188731

Patch Set 1 #

Messages

Total messages: 9 (1 generated)
rune
5 years, 11 months ago (2015-01-14 10:41:21 UTC) #1
rune
PTAL
5 years, 11 months ago (2015-01-16 13:43:14 UTC) #2
esprehn
It seems like this uncovered a bug in first letter? Why would anything change styles ...
5 years, 11 months ago (2015-01-16 18:52:27 UTC) #3
rune
On 2015/01/16 18:52:27, esprehn wrote: > It seems like this uncovered a bug in first ...
5 years, 11 months ago (2015-01-19 14:07:21 UTC) #4
rune
@esprehn: I've reported the issue and landed a test-case for the bug that materialized in ...
5 years, 11 months ago (2015-01-21 07:53:44 UTC) #5
esprehn
lgtm
5 years, 11 months ago (2015-01-21 08:55:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/829393005/1
5 years, 11 months ago (2015-01-21 09:11:17 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 10:25:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188731

Powered by Google App Engine
This is Rietveld 408576698