Move CrWinClang and Tester to recipes.

Move CrWinClang and Tester to recipes.

BUG=446368
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293632

[Nico, 2015-01-14 04:32:03]

thakis@chromium.org changed reviewers:
+ iannucci@chromium.org

[Nico, 2015-01-14 04:32:04]

\noideanico{}, so please look carefully.

Related: https://codereview.chromium.org/854523002/

I'm moving the first two boxes on
build.chromium.org/p/chromium.fyi/console?category=win%20clang first, and if
that works out I'll move the rest.

[iannucci, 2015-01-14 05:23:45]

iannucci@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[iannucci, 2015-01-14 05:23:45]

+pawel in case he can review in the overnight :)

[iannucci, 2015-01-14 05:30:08]

lgtm, but I'd wait for Pawel

https://codereview.chromium.org/829363004/diff/20001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/chromium/chromium_fyi.py (right):

https://codereview.chromium.org/829363004/diff/20001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/chromium/chromium_fyi.py:402: 'CrWinClang Tester':
{
I think there's a 'Tester' v. 'tester' discrepancy here w/ the master config.

https://codereview.chromium.org/829363004/diff/20001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/chromium/chromium_fyi.py:412: 'parent_buildername':
'CrWinClang',
[aside, to no one in particular: WTF is this... we know the parent_buildername
from the properties....]

https://codereview.chromium.org/829363004/diff/20001/scripts/slave/recipes/ch...
File scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang.json
(right):

https://codereview.chromium.org/829363004/diff/20001/scripts/slave/recipes/ch...
scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang.json:79:
"GYP_DEFINES": "clang=1 component=static_library target_arch=ia32"
I would make sure these GYP_DEFINES are how you want them. They'll be exactly
like this on the waterfall.

[Nico, 2015-01-14 06:03:36]

https://codereview.chromium.org/829363004/diff/20001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/chromium/chromium_fyi.py (right):

https://codereview.chromium.org/829363004/diff/20001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/chromium/chromium_fyi.py:402: 'CrWinClang Tester':
{
On 2015/01/14 05:30:08, iannucci wrote:
> I think there's a 'Tester' v. 'tester' discrepancy here w/ the master config.

Excellent catch, thanks. Will fix.

https://codereview.chromium.org/829363004/diff/20001/scripts/slave/recipes/ch...
File scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang.json
(right):

https://codereview.chromium.org/829363004/diff/20001/scripts/slave/recipes/ch...
scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang.json:79:
"GYP_DEFINES": "clang=1 component=static_library target_arch=ia32"
On 2015/01/14 05:30:08, iannucci wrote:
> I would make sure these GYP_DEFINES are how you want them. They'll be exactly
> like this on the waterfall.

Yup, I checked that this is identical to the GYP_DEFINES in
http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/1218/step...
(well, the bot doesn't have an explicitly set target_arch, but that's the same
as target_arch=ia32. I suppose I could maybe remove the TARGET_BITS setting, but
either way seems fine.)

[Paweł Hajdan Jr., 2015-01-14 14:57:03]

LGTM

https://codereview.chromium.org/829363004/diff/20001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/chromium/chromium_fyi.py (right):

https://codereview.chromium.org/829363004/diff/20001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/chromium/chromium_fyi.py:412: 'parent_buildername':
'CrWinClang',
On 2015/01/14 05:30:08, iannucci wrote:
> [aside, to no one in particular: WTF is this... we know the parent_buildername
> from the properties....]

We don't have that at recipe expectation training time. Suggestions for
improvements are welcome, there are some legacy things here that could be
cleaned up for sure.

[Nico, 2015-01-14 18:41:54]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-01-14 18:42:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/829363004/40001

[commit-bot: I haz the power, 2015-01-14 18:43:21]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293632