Issue 829333004: Add DictionaryValue::Set and ::SetWithoutPathExpansion fns

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 829333004: Add DictionaryValue::Set and ::SetWithoutPathExpansion fns (Closed)

Created:
5 years, 11 months ago by Evan Stade

Modified:
5 years, 11 months ago

Reviewers:
brettw

CC:
chromium-reviews, dbeam+watch-options_chromium.org, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add DictionaryValue::Set and ::SetWithoutPathExpansion functions that take scoped_ptr. Mark the non-scoped_ptr versions as deprecated. Update tests. Update one client. BUG=446238 Committed: https://crrev.com/ca798484cbd3b3b305bc02454d17d88d751c453c Cr-Commit-Position: refs/heads/master@{#310121}

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -40 lines)			Patch
M	base/values.h	View	2 chunks	+6 lines, -3 lines	0 comments	Download
M	base/values.cc	View	3 chunks	+16 lines, -6 lines	0 comments	Download
M	base/values_unittest.cc	View	7 chunks	+42 lines, -16 lines	0 comments	Download
M	chrome/browser/ui/webui/options/website_settings_handler.cc	View	7 chunks	+16 lines, -15 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/829333004/1

5 years, 11 months ago (2015-01-06 17:44:03 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2015-01-06 20:09:14 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ca798484cbd3b3b305bc02454d17d88d751c453c
Cr-Commit-Position: refs/heads/master@{#310121}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages