[rAc OSX] Simplify the overlay controller.

[rAc OSX] Simplify the overlay controller.

* Remove code handling the case where the overlay doesn't include any text.
* Remove remnants of code handling opacity transitions.

BUG=none
TEST=none
R=groby@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236916

[groby-ooo-7-16, 2013-11-22 14:24:02]

Yay for simplicity!

LGTM unless you want to roll then contentView thing into this CL

https://codereview.chromium.org/82933002/diff/1/chrome/browser/ui/cocoa/autof...
File chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.h (left):

https://codereview.chromium.org/82933002/diff/1/chrome/browser/ui/cocoa/autof...
chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.h:26:
base::scoped_nsobject<NSView> childView_;
All that pain, for naught...

Since we're not doing any transitions any more, I think we should consider
switching the main window a bit - changing states should simply switch the
contentView. That should simplify a lot of the logic where we fiddle around with
isHidden

https://codereview.chromium.org/82933002/diff/1/chrome/browser/ui/cocoa/autof...
File chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.mm (right):

https://codereview.chromium.org/82933002/diff/1/chrome/browser/ui/cocoa/autof...
chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.mm:146: [view
setFillColor:[[view window] backgroundColor]];
This could also go if we just change contentView...

[Ilya Sherman, 2013-11-22 22:15:57]

On 2013/11/22 14:24:02, groby wrote:
> Yay for simplicity!
> 
> LGTM unless you want to roll then contentView thing into this CL

I'm concerned that changing the contentView might have other side-effects.  For
example, when I just changed the firstResponder, I saw that 'Esc' stopped
working to exit out of the dialog.  So, while it might the Right Thing™ to do,
I'd rather push it off to a separate CL.

[commit-bot: I haz the power, 2013-11-22 22:16:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/82933002/1

[commit-bot: I haz the power, 2013-11-22 23:14:35]

Retried try job too often on mac_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-11-22 23:44:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/82933002/40002

[commit-bot: I haz the power, 2013-11-23 01:07:43]

Retried try job too often on linux_rel for step(s) check_deps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-11-23 01:14:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/82933002/40002

[commit-bot: I haz the power, 2013-11-23 01:48:11]

Change committed as 236916