Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 829313004: Retire unnecessary ScriptStreamer back reference from SourceStream. (Closed)

Created:
5 years, 11 months ago by sof
Modified:
5 years, 11 months ago
Reviewers:
haraken, marja
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Retire unnecessary ScriptStreamer back reference from SourceStream. Passing along the ScriptStreamer reference when needed is simpler. R=marja BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188140

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M Source/bindings/core/v8/ScriptStreamer.cpp View 7 chunks +10 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
Please take a look.
5 years, 11 months ago (2015-01-09 09:27:09 UTC) #2
marja
lgtm
5 years, 11 months ago (2015-01-09 09:28:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/829313004/1
5 years, 11 months ago (2015-01-09 09:33:34 UTC) #5
haraken
LGTM
5 years, 11 months ago (2015-01-09 09:34:00 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 10:38:31 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188140

Powered by Google App Engine
This is Rietveld 408576698