Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 829303002: [turbofan] Generalize constant propagation. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Generalize constant propagation. Also support additional number types (singleton ranges, NaN and minus zero) for constant propagation in typed lowering. TEST=unittests Committed: https://crrev.com/ec35c52e54e5ca55afd62f7eb2a5f11e1fff3554 Cr-Commit-Position: refs/heads/master@{#25963}

Patch Set 1 #

Patch Set 2 : Fix compilation on Mac #

Total comments: 4

Patch Set 3 : Add test case for -0|0. #

Patch Set 4 : Fix minus zero handling. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -6 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 2 3 1 chunk +28 lines, -6 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 2 3 3 chunks +126 lines, -0 lines 0 comments Download
M testing/gmock-support.h View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Benedikt Meurer
PTAL
5 years, 11 months ago (2015-01-05 08:11:33 UTC) #2
Jarin
lgtm with non-blocking questions. https://codereview.chromium.org/829303002/diff/20001/src/compiler/js-typed-lowering.cc File src/compiler/js-typed-lowering.cc (right): https://codereview.chromium.org/829303002/diff/20001/src/compiler/js-typed-lowering.cc#newcode930 src/compiler/js-typed-lowering.cc:930: // result value and can ...
5 years, 11 months ago (2015-01-05 09:41:22 UTC) #3
Benedikt Meurer
Done. Requires fixes to handle -0 correctly in the type system. https://codereview.chromium.org/829303002/diff/20001/src/compiler/js-typed-lowering.cc File src/compiler/js-typed-lowering.cc (right): ...
5 years, 11 months ago (2015-01-05 12:37:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/829303002/40001
5 years, 11 months ago (2015-01-05 13:05:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/2146)
5 years, 11 months ago (2015-01-05 13:23:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/829303002/40001
5 years, 11 months ago (2015-01-05 17:34:15 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/2027)
5 years, 11 months ago (2015-01-05 17:50:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/829303002/60001
5 years, 11 months ago (2015-01-07 07:57:56 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-07 08:24:33 UTC) #15
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 08:24:49 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ec35c52e54e5ca55afd62f7eb2a5f11e1fff3554
Cr-Commit-Position: refs/heads/master@{#25963}

Powered by Google App Engine
This is Rietveld 408576698