Issue 8293002: GTK: Remove the global bookmark menu code. It's been behind a flag and bitrotting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8293002: GTK: Remove the global bookmark menu code. It's been behind a flag and bitrotting. (Closed)

Created:
9 years, 2 months ago by Elliot Glaysher

Modified:
9 years, 2 months ago

Reviewers:
commit-bot: I haz the power, Evan Stade

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

GTK: Remove the global bookmark menu code. It's been behind a flag and bitrotting. BUG=86715, 85466 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105841

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -438 lines)			Patch
D	chrome/browser/ui/gtk/global_bookmark_menu.h	View	1 chunk	+0 lines, -127 lines	0 comments	Download
D	chrome/browser/ui/gtk/global_bookmark_menu.cc	View	1 chunk	+0 lines, -268 lines	0 comments	Download
M	chrome/browser/ui/gtk/global_menu_bar.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/gtk/global_menu_bar.cc	View	3 chunks	+0 lines, -25 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

We can pull this out of history if we want to revive the experiment, but ...

9 years, 2 months ago (2011-10-14 17:58:21 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8293002/1

9 years, 2 months ago (2011-10-14 21:01:51 UTC) #3

commit-bot: I haz the power

9 years, 2 months ago (2011-10-15 01:43:06 UTC) #4

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is mac_rel, revision is 105604, job name
was 8293002-1 (previous was lost) (retry) (previous was lost) (previous was
lost).

Expand Messages | Collapse Messages