Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 82923005: Add "ninja show" and "ninja refresh" targets to GN build. (Closed)

Created:
7 years, 1 month ago by brettw
Modified:
7 years, 1 month ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Add "ninja show" and "ninja refresh" targets to GN build. "ninja show" will print out the build arguments for when you can't remember the configuration of your output directory. "ninja refresh" ignores dependencies and regenerates the ninja files. R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236840

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M tools/gn/ninja_build_writer.cc View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
brettw
7 years, 1 month ago (2013-11-22 20:48:48 UTC) #1
scottmg
https://codereview.chromium.org/82923005/diff/1/tools/gn/ninja_build_writer.cc File tools/gn/ninja_build_writer.cc (right): https://codereview.chromium.org/82923005/diff/1/tools/gn/ninja_build_writer.cc#newcode145 tools/gn/ninja_build_writer.cc:145: out_ << "\nbuild refresh: gn\n"; This would break if ...
7 years, 1 month ago (2013-11-22 20:53:21 UTC) #2
brettw
I fixed the comment. I did not change the build names. "ninja foo" will always ...
7 years, 1 month ago (2013-11-22 21:20:31 UTC) #3
scottmg
ok, lgtm
7 years, 1 month ago (2013-11-22 21:23:38 UTC) #4
brettw
7 years, 1 month ago (2013-11-22 22:14:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r236840 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698