Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 8292006: Disable warning the user if a webRequest extension misbehaves (Closed)

Created:
9 years, 2 months ago by battre
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Disable warning the user if a webRequest extension misbehaves Disable warning the user if a webRequest extension misbehaves by delaying requests for too long as we do not have a sensible definition for "too long", yet. BUG=no TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105720

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M chrome/browser/extensions/extension_webrequest_time_tracker.cc View 5 chunks +17 lines, -11 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
battre
Could you please review this? Hoping that no compiler complains about nobody using NotifyNetworkDelaysOnUI. Thx.
9 years, 2 months ago (2011-10-14 23:15:35 UTC) #1
Matt Perry
lgtm http://codereview.chromium.org/8292006/diff/1/chrome/browser/extensions/extension_webrequest_time_tracker.cc File chrome/browser/extensions/extension_webrequest_time_tracker.cc (right): http://codereview.chromium.org/8292006/diff/1/chrome/browser/extensions/extension_webrequest_time_tracker.cc#newcode38 chrome/browser/extensions/extension_webrequest_time_tracker.cc:38: DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); why not just comment out the implementation ...
9 years, 2 months ago (2011-10-14 23:18:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/8292006/1
9 years, 2 months ago (2011-10-15 00:27:03 UTC) #3
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 2 months ago (2011-10-15 05:50:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/8292006/1
9 years, 2 months ago (2011-10-15 15:16:21 UTC) #5
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 2 months ago (2011-10-15 18:08:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/8292006/1
9 years, 2 months ago (2011-10-16 03:42:21 UTC) #7
commit-bot: I haz the power
9 years, 2 months ago (2011-10-16 05:21:32 UTC) #8
Change committed as 105720

Powered by Google App Engine
This is Rietveld 408576698