Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 8292003: Total now reads mortgage sample from server (Closed)

Created:
9 years, 2 months ago by rchandia
Modified:
9 years, 2 months ago
Reviewers:
Søren Gjesse, Dan Rice
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Total now reads mortgage sample from server Removed example SYLK from client To get as SYLK spreadsheet named 'foo' http://localhost:9090/spreadsheet/get?name=foo To get a list of available spreasheets as a JSON array of Strings http://localhost:9090/spreadsheet/list For now the options are: - empty - mortgage - collatz - insertTest Fixed stale calls to String.substringToEnd() (issue 128) R=rice@google.com BUG=128 TEST= Committed: https://code.google.com/p/dart/source/detail?r=634

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review comments #

Patch Set 3 : Fix Process stdout and stderr renames #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -172 lines) Patch
M client/samples/total/src/SYLKReader.dart View 1 2 chunks +32 lines, -161 lines 0 comments Download
M client/samples/total/src/Total.dart View 1 chunk +9 lines, -7 lines 0 comments Download
M samples/total/src/Dartc.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A samples/total/src/GetSpreadsheet.dart View 1 1 chunk +38 lines, -0 lines 0 comments Download
A samples/total/src/SYLKProducer.dart View 1 1 chunk +192 lines, -0 lines 0 comments Download
M samples/total/src/TotalRunner.dart View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M samples/total/src/TotalServer.dart View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Søren Gjesse
The stale calls to substringToEnd where fixed inhttp://code.google.com/p/dart/source/detail?r=578.
9 years, 2 months ago (2011-10-21 11:41:31 UTC) #1
rchandia
On 2011/10/21 11:41:31, Søren Gjesse wrote: > The stale calls to substringToEnd where fixed > ...
9 years, 2 months ago (2011-10-21 14:01:03 UTC) #2
Dan Rice
LGTM http://codereview.chromium.org/8292003/diff/1/samples/total/src/GetSpreadsheet.dart File samples/total/src/GetSpreadsheet.dart (right): http://codereview.chromium.org/8292003/diff/1/samples/total/src/GetSpreadsheet.dart#newcode14 samples/total/src/GetSpreadsheet.dart:14: case 'POST': Note fallthrough http://codereview.chromium.org/8292003/diff/1/samples/total/src/GetSpreadsheet.dart#newcode29 samples/total/src/GetSpreadsheet.dart:29: Remove blank ...
9 years, 2 months ago (2011-10-21 15:50:50 UTC) #3
rchandia
http://codereview.chromium.org/8292003/diff/1/samples/total/src/GetSpreadsheet.dart File samples/total/src/GetSpreadsheet.dart (right): http://codereview.chromium.org/8292003/diff/1/samples/total/src/GetSpreadsheet.dart#newcode14 samples/total/src/GetSpreadsheet.dart:14: case 'POST': On 2011/10/21 15:50:50, Dan Rice wrote: > ...
9 years, 2 months ago (2011-10-24 16:47:31 UTC) #4
rchandia
Submitted r634
9 years, 2 months ago (2011-10-24 16:49:05 UTC) #5
rchandia
9 years, 2 months ago (2011-10-24 21:01:04 UTC) #6
Reverted at r652

On 2011/10/24 16:49:05, rchandia wrote:
> Submitted r634

Powered by Google App Engine
This is Rietveld 408576698