Always use mojo_shell in over-http mode

sky/tools/debugger/prompt/prompt.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/debug/profiler.h"
 #include "base/memory/weak_ptr.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 84 matching lines @@
       StartProfiling(connection_id);
     else if (info.path == "/stop_profiling")
       StopProfiling(connection_id);
     else {
       Help(info.path, connection_id);
     }
   }
 
   void OnWebSocketRequest(
       int connection_id, const net::HttpServerRequestInfo& info) override {
-    web_server_->Send500(connection_id, "http only");
+    Error(connection_id, "OnWebSocketRequest not implemented");
   }
 
   void OnWebSocketMessage(
       int connection_id, const std::string& data) override {
-    web_server_->Send500(connection_id, "http only");
+    Error(connection_id, "OnWebSocketMessage not implemented");
+  }
+
+  void Error(int connection_id, std::string message) {
+    web_server_->Send500(connection_id, message);
   }
 
   void Respond(int connection_id, std::string response) {
     // When sending tracing data back over the wire to the client, we can blow
     // through the default send buffer size.
     web_server_->SetSendBufferSize(
         connection_id, std::max(kMinSendBufferSize, response.length()));
     web_server_->Send200(connection_id, response, "text/plain");
   }
 
@@ skipping 49 matching lines @@
     trace_collector_.reset(new TraceCollector(pipe.consumer_handle.Pass()));
     Respond(connection_id, "Starting trace (type 'trace' to stop tracing)\n");
   }
 
   void OnTraceAvailable(int connection_id, std::string trace) {
     trace_collector_.reset();
     Respond(connection_id, trace);
   }
 
   void StartProfiling(int connection_id) {
+#if !defined(NDEBUG) || !defined(ENABLE_PROFILING)
+    Error(connection_id,
+        "Profiling requires debug=false and enable_profiling=true");

[abarth-chromium, 2015/01/21 22:18:49]

debug=false -> is_debug=false

[eseidel, 2015/01/21 22:44:43]

Done.

+    return;
+#else
     base::debug::StartProfiling("sky_viewer.pprof");
     Respond(connection_id, "Starting profiling (stop with 'stop_profiling')");
+#endif
   }
 
   void StopProfiling(int connection_id) {
+    if (!base::debug::BeingProfiled()) {
+      Error(connection_id, "Profiling not started");
+      return;
+    }
     base::debug::StopProfiling();
     Respond(connection_id, "Stopped profiling");
   }
 
   bool is_tracing_;
   DebuggerPtr debugger_;
   tracing::TraceCoordinatorPtr tracing_;
   std::string url_;
   base::WeakPtrFactory<Prompt> weak_ptr_factory_;
   scoped_ptr<net::HttpServer> web_server_;
   uint32_t command_port_;
 
   scoped_ptr<TraceCollector> trace_collector_;
 
   DISALLOW_COPY_AND_ASSIGN(Prompt);
 };
 
 }  // namespace debugger
 }  // namespace sky
 
 MojoResult MojoMain(MojoHandle shell_handle) {
   mojo::ApplicationRunnerChromium runner(new sky::debugger::Prompt);
   runner.set_message_loop_type(base::MessageLoop::TYPE_IO);
   return runner.Run(shell_handle);
 }