Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 829133009: Remove command line flag --disable-plugins (Closed)

Created:
5 years, 11 months ago by MRV
Modified:
5 years, 11 months ago
CC:
chromium-reviews, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove command line flag --disable-plugins BUG=366349 Committed: https://crrev.com/33e1a450280da7d8fcec4d5403ece0f36c7c5b67 Cr-Commit-Position: refs/heads/master@{#311475}

Patch Set 1 #

Patch Set 2 : Rebased patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M chromecast/browser/cast_browser_main_parts.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
MRV
kolla@chromium.org: Please review changes in chromecast avi@chromium.org: Please review changes in content PTAL
5 years, 11 months ago (2015-01-09 07:37:42 UTC) #2
Avi (use Gerrit)
lgtm
5 years, 11 months ago (2015-01-09 14:55:10 UTC) #3
MRV
On 2015/01/09 14:55:10, Avi wrote: > lgtm Thanks mr.avi for your review. @kollas could you ...
5 years, 11 months ago (2015-01-10 03:29:00 UTC) #4
MRV
On 2015/01/10 03:29:00, MRV wrote: > On 2015/01/09 14:55:10, Avi wrote: > > lgtm > ...
5 years, 11 months ago (2015-01-14 02:42:26 UTC) #6
lcwu1
chromecast lgtm
5 years, 11 months ago (2015-01-14 03:13:37 UTC) #7
MRV
On 2015/01/14 03:13:37, lcwu1 wrote: > chromecast lgtm thanks icwc1 for your time and review.
5 years, 11 months ago (2015-01-14 04:55:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/829133009/1
5 years, 11 months ago (2015-01-14 04:55:39 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/48533) android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/49403) linux_chromium_asan_rel ...
5 years, 11 months ago (2015-01-14 04:58:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/829133009/20001
5 years, 11 months ago (2015-01-14 14:23:28 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-14 15:17:49 UTC) #15
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 15:18:50 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/33e1a450280da7d8fcec4d5403ece0f36c7c5b67
Cr-Commit-Position: refs/heads/master@{#311475}

Powered by Google App Engine
This is Rietveld 408576698