runtime/vm/assembler_x64.h - Issue 829133006: VM: Small generated code size improvements on x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/assembler_x64.h

Issue 829133006: VM: Small generated code size improvements on x64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: addressed comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/assembler_x64.h

===================================================================

--- runtime/vm/assembler_x64.h (revision 42687)

+++ runtime/vm/assembler_x64.h (working copy)

@@ -352,7 +352,8 @@

void call(Label* label);

void call(const ExternalLabel* label);

- static const intptr_t kCallExternalLabelSize = 10;

+ static const intptr_t kCallExternalLabelSize = 7;

+ static const intptr_t kJmpExternalLabelSize = 10;

void pushq(Register reg);

void pushq(const Address& address);

@@ -726,7 +727,7 @@

void SubImmediate(Register reg, const Immediate& imm, Register pp);

void SubImmediate(const Address& address, const Immediate& imm, Register pp);

- void Drop(intptr_t stack_elements);

+ void Drop(intptr_t stack_elements, Register tmp = TMP);

enum Patchability {

kPatchable,

« no previous file with comments | « no previous file | runtime/vm/assembler_x64.cc » ('j') | no next file with comments »