Issue 82913007: Add CanCloseDialog to WebDialogDelegate to allow blocking closing of dialog if needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 82913007: Add CanCloseDialog to WebDialogDelegate to allow blocking closing of dialog if needed. (Closed)

Created:
7 years, 1 month ago by jennyz

Modified:
7 years ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add CanCloseDialog to WebDialogDelegate to allow blocking closing of dialog if needed. There are some use cases that we don't allow user to close the web dialog until they have finish the UI flow and confirmed some important information. Currently, WebDialogDelegate can't control the closing of the dialog if user presses the "x" button on dialog title bar or presses Esc shortcut key. I am adding a CanClose() method to allow the subclass to block the dialog close if it needs to do so. BUG=322614 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238193

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -0 lines)			Patch
M	ui/views/controls/webview/web_dialog_view.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	ui/web_dialogs/web_dialog_delegate.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	ui/web_dialogs/web_dialog_delegate.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/82913007/1

7 years ago (2013-12-02 19:07:26 UTC) #3

Message was sent while issue was closed.

Change committed as 238193

Expand Messages | Collapse Messages