Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 82913006: I feel like my clang is especially sensitive to unused variables. (Closed)

Created:
7 years, 1 month ago by mtklein
Modified:
7 years, 1 month ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

I feel like my clang is especially sensitive to unused variables. BUG= Committed: https://code.google.com/p/skia/source/detail?r=12369

Patch Set 1 #

Patch Set 2 : correct guard #

Patch Set 3 : reup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M src/core/SkMatrix.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download
M tests/PathOpsAngleTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mtklein
7 years, 1 month ago (2013-11-22 20:39:06 UTC) #1
mtklein
7 years, 1 month ago (2013-11-22 20:43:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #3 manually as r12369 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698