Fix WebCore -> blink changes in VS debugger visualizers.

Fix WebCore -> blink changes in VS debugger visualizers.

Visual Studio type visualizers need to be updated to reflect
that blink uses the blink namespace instead of WebCore now. Otherwise
you won't get the readable view of LayoutUnit/LayoutPoint/LayoutRect.

R=zturner@chromium.org
BUG=

Committed: https://crrev.com/56a8939968f2989b3ed4eda5c13e0143f5890c05
Cr-Commit-Position: refs/heads/master@{#312224}

[Daniel Bratell, 2015-01-20 16:54:49]

bratell@opera.com changed reviewers:
+ zturner@chromium.org

[Daniel Bratell, 2015-01-20 16:54:49]

zturner, can you please take a look at this update of a VS visualizer?

[zturner, 2015-01-20 17:04:40]

There's no functionality change here, so as long as you've tested it and it
works, then lgtm
On Tue, Jan 20, 2015 at 8:54 AM <bratell@opera.com> wrote:

> Reviewers: zturner,
>
> Message:
> zturner, can you please take a look at this update of a VS visualizer?
>
>
> Description:
> Fix WebCore -> blink changes in VS debugger visualizers.
>
> Visual Studio type visualizers need to be updated to reflect
> that blink uses the blink namespace instead of WebCore now. Otherwise
> you won't get the readable view of LayoutUnit/LayoutPoint/LayoutRect.
>
> R=zturner@chromium.org
> BUG=
>
> Please review this at https://codereview.chromium.org/829093003/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+10, -10 lines):
>    M tools/win/DebugVisualizers/webkit.natvis
>
>
> Index: tools/win/DebugVisualizers/webkit.natvis
> diff --git a/tools/win/DebugVisualizers/webkit.natvis
> b/tools/win/DebugVisualizers/webkit.natvis
> index
> de7f17502cbb8552e620ac787767bd8a74900ebb..6e93438f2a0a28721f58c8b50147fd
> ba7c8cae55
> 100644
> --- a/tools/win/DebugVisualizers/webkit.natvis
> +++ b/tools/win/DebugVisualizers/webkit.natvis
> @@ -45,34 +45,34 @@
>         <Item Name="Ptr">m_ptr</Item>
>       </Expand>
>     </Type>
> -  <Type Name="WebCore::LayoutUnit">
> +  <Type Name="blink::LayoutUnit">
>       <DisplayString>{(float)m_value /
> kFixedPointDenominator}</DisplayString>
>       <Expand>
>         <Item Name="FloatVal">(float)m_value /
> kFixedPointDenominator</Item>
>         <Item Name="RawVal">m_value</Item>
>       </Expand>
>     </Type>
> -  <Type Name="WebCore::LayoutSize">
> -    <AlternativeType Name="WebCore::IntSize"/>
> -    <AlternativeType Name="WebCore::FloatSize"/>
> +  <Type Name="blink::LayoutSize">
> +    <AlternativeType Name="blink::IntSize"/>
> +    <AlternativeType Name="blink::FloatSize"/>
>       <DisplayString>({m_width}, {m_height})</DisplayString>
>       <Expand>
>         <Item Name="Width">m_width</Item>
>         <Item Name="Height">m_height</Item>
>       </Expand>
>     </Type>
> -  <Type Name="WebCore::LayoutPoint">
> -    <AlternativeType Name="WebCore::IntPoint"/>
> -    <AlternativeType Name="WebCore::FloatPoint"/>
> +  <Type Name="blink::LayoutPoint">
> +    <AlternativeType Name="blink::IntPoint"/>
> +    <AlternativeType Name="blink::FloatPoint"/>
>       <DisplayString>({m_x}, {m_y})</DisplayString>
>       <Expand>
>         <Item Name="X">m_x</Item>
>         <Item Name="Y">m_y</Item>
>       </Expand>
>     </Type>
> -  <Type Name="WebCore::LayoutRect">
> -    <AlternativeType Name="WebCore::IntRect"/>
> -    <AlternativeType Name="WebCore::FloatRect"/>
> +  <Type Name="blink::LayoutRect">
> +    <AlternativeType Name="blink::IntRect"/>
> +    <AlternativeType Name="blink::FloatRect"/>
>       <DisplayString>({m_location.m_x}, {m_location.m_y}) x
> ({m_size.m_width}, {m_size.m_height})</DisplayString>
>       <Expand>
>         <Item Name="Location">m_location</Item>
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Daniel Bratell, 2015-01-20 17:20:31]

Hmm, it didn't go green. Do you need to write it in uppercase or something?

[zturner, 2015-01-20 17:31:09]

lgtm

[zturner, 2015-01-20 17:31:31]

On 2015/01/20 17:31:09, zturner wrote:
> lgtm

I lgtm'ed from email previously, guess I need to physically log in to the
website and do it here now.

[Daniel Bratell, 2015-01-20 17:42:22]

The CQ bit was checked by bratell@opera.com

[commit-bot: I haz the power, 2015-01-20 17:42:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/829093003/1

[commit-bot: I haz the power, 2015-01-20 18:24:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-01-20 18:25:08]

Patchset 1 (id:??) landed as
https://crrev.com/56a8939968f2989b3ed4eda5c13e0143f5890c05
Cr-Commit-Position: refs/heads/master@{#312224}