editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/timing/HtmlParserTimings.java - Issue 82903007: Improved HTML parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/timing/HtmlParserTimings.java

Issue 82903007: Improved HTML parsing (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Clean-up Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/cache/HtmlEntryImplTest.java ('K') | « editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/html/HtmlTagInfoBuilderTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/timing/HtmlParserTimings.java

diff --git a/editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/timing/HtmlParserTimings.java b/editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/timing/HtmlParserTimings.java

index 6362ca9d6ce563dd71ea5fd6f60ee2b74f400842..f21cff84befe37b8b113caf88df64fc02f3fd736 100644

--- a/editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/timing/HtmlParserTimings.java

+++ b/editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/timing/HtmlParserTimings.java

@@ -1,5 +1,6 @@

package com.google.dart.tools.core.analysis.timing;

+import com.google.dart.engine.error.GatheringErrorListener;

import com.google.dart.engine.html.parser.HtmlParseResult;

import com.google.dart.engine.html.parser.HtmlParser;

import com.google.dart.engine.source.FileBasedSource;

@@ -29,7 +30,8 @@ public class HtmlParserTimings extends TestCase {

@Override

public void run(File htmlFile) throws Exception {

Source source = new FileBasedSource(sourceFactory.getContentCache(), htmlFile);

- HtmlParseResult parseResult = new HtmlParser(source).parse(source);

+ GatheringErrorListener errorListener = new GatheringErrorListener();

+ HtmlParseResult parseResult = new HtmlParser(source, errorListener).parse(source);

assertNotNull(parseResult);

}

};

@@ -41,7 +43,8 @@ public class HtmlParserTimings extends TestCase {

public void run(File htmlFile, String contents) throws Exception {

Source source = new FileBasedSource(sourceFactory.getContentCache(), htmlFile);

sourceFactory.setContents(source, contents);

- HtmlParseResult parseResult = new HtmlParser(source).parse(source);

+ GatheringErrorListener errorListener = new GatheringErrorListener();

+ HtmlParseResult parseResult = new HtmlParser(source, errorListener).parse(source);

assertNotNull(parseResult);

}

};