Source/modules/gamepad/NavigatorGamepad.cpp - Issue 828983002: Do not (re)start NavigatorGamepad updating once detached.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/gamepad/NavigatorGamepad.cpp

Issue 828983002: Do not (re)start NavigatorGamepad updating once detached. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Simply refuse to (re)start updating when detached Created 5 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/gamepad/NavigatorGamepad.cpp

diff --git a/Source/modules/gamepad/NavigatorGamepad.cpp b/Source/modules/gamepad/NavigatorGamepad.cpp

index 0846608d4fd11bf2265318aca4aa0dd90448c76c..3cbc3f912c9cc66f9578eac7988de58ebf65c58d 100644

--- a/Source/modules/gamepad/NavigatorGamepad.cpp

+++ b/Source/modules/gamepad/NavigatorGamepad.cpp

@@ -97,7 +97,8 @@ GamepadList* NavigatorGamepad::gamepads()

{

if (!m_gamepads)

m_gamepads = GamepadList::create();

- if (frame() && frame()->domWindow()) {

+ if (frame() && frame()->host()) {

+ // The frame must be attached to start updating.

startUpdating();

sampleGamepads<Gamepad>(m_gamepads.get());

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »