Issue 8289008: Disambiguate non-incremental mode from optimized mode in dartc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8289008: Disambiguate non-incremental mode from optimized mode in dartc (Closed)

Created:
9 years, 2 months ago by jbrosenberg

Modified:
9 years, 2 months ago

Reviewers:
codefu

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Disambiguate non-incremental mode from optimized mode in dartc Committed: https://code.google.com/p/dart/source/detail?r=469

Patch Set 1 #

Total comments: 1

Patch Set 2 : Renamed some variables for readability" #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	compiler/java/com/google/dart/compiler/DartCompiler.java	View	1	6 chunks	+7 lines, -5 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jbrosenberg

This makes it possible to test repeated full compiles, but still use pre-compiled system libs ...

9 years, 2 months ago (2011-10-14 19:42:54 UTC) #1

codefu

9 years, 2 months ago (2011-10-14 20:25:12 UTC) #2

LGTM

http://codereview.chromium.org/8289008/diff/3/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/DartCompiler.java (right):

http://codereview.chromium.org/8289008/diff/3/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/DartCompiler.java:200: boolean
apiOutOfDate = !(shouldLoadApi && apiLib.loadApi(context, context));
Groks much better!

Expand Messages | Collapse Messages