Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1667)

Unified Diff: src/IceTargetLowering.cpp

Issue 828873002: Subzero: Start writing out some relocation sections (text) (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: review fixes Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceTargetLowering.h ('k') | src/IceTargetLoweringX8632.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTargetLowering.cpp
diff --git a/src/IceTargetLowering.cpp b/src/IceTargetLowering.cpp
index c20f9f6a05cde57a7fe4867943afb2688bc9bfe1..b04727de47d24742dc2333276ed166aad8307f55 100644
--- a/src/IceTargetLowering.cpp
+++ b/src/IceTargetLowering.cpp
@@ -107,11 +107,12 @@ TargetLowering::TargetLowering(Cfg *Func)
HasComputedFrame(false), CallsReturnsTwice(false), StackAdjustment(0),
Context() {}
-Assembler *TargetLowering::createAssembler(TargetArch Target, Cfg *Func) {
+std::unique_ptr<Assembler> TargetLowering::createAssembler(TargetArch Target,
+ Cfg *Func) {
// These statements can be #ifdef'd to specialize the assembler
// to a subset of the available targets. TODO: use CRTP.
if (Target == Target_X8632)
- return new x86::AssemblerX86();
+ return std::unique_ptr<Assembler>(new x86::AssemblerX86());
Func->setError("Unsupported target");
return nullptr;
}
« no previous file with comments | « src/IceTargetLowering.h ('k') | src/IceTargetLoweringX8632.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698