Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 828853004: Fix some errors in GN files for content. (Closed)

Created:
5 years, 11 months ago by Slava Chigrin
Modified:
5 years, 11 months ago
Reviewers:
jam, no sievers
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some errors in GN files for content. Committed: https://crrev.com/fd9bd7de3cae1a028a7d6426666dd3b33019adcf Cr-Commit-Position: refs/heads/master@{#311429}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M content/common/BUILD.gn View 1 chunk +14 lines, -0 lines 1 comment Download
M content/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Slava Chigrin
https://codereview.chromium.org/828853004/diff/1/content/common/BUILD.gn File content/common/BUILD.gn (right): https://codereview.chromium.org/828853004/diff/1/content/common/BUILD.gn#newcode358 content/common/BUILD.gn:358: "d3d9.lib", Done like this code in GYP https://code.google.com/p/chromium/codesearch#chromium/src/content/content_common.gypi&q=d3d9.lib&sq=package:chromium&l=934&type=cs
5 years, 11 months ago (2015-01-13 19:17:00 UTC) #2
no sievers
lgtm
5 years, 11 months ago (2015-01-13 20:18:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/828853004/1
5 years, 11 months ago (2015-01-14 07:18:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/48857)
5 years, 11 months ago (2015-01-14 07:22:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/828853004/1
5 years, 11 months ago (2015-01-14 08:25:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 08:35:51 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 08:36:50 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fd9bd7de3cae1a028a7d6426666dd3b33019adcf
Cr-Commit-Position: refs/heads/master@{#311429}

Powered by Google App Engine
This is Rietveld 408576698