Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 828803004: [turbofan] Improve memory layout of Node class. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
Sven Panne, dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Improve memory layout of Node class. Also gets rid of the reinterpret_cast on this. R=svenpanne@chromium.org Committed: https://crrev.com/f91e8046fad99365c74ccbb39d42de58398dab57 Cr-Commit-Position: refs/heads/master@{#26103}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M src/compiler/node.h View 2 chunks +10 lines, -9 lines 0 comments Download
M src/compiler/node.cc View 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
Benedikt Meurer
5 years, 11 months ago (2015-01-16 12:06:35 UTC) #1
Benedikt Meurer
PTAL
5 years, 11 months ago (2015-01-16 12:06:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/828803004/1
5 years, 11 months ago (2015-01-16 12:46:35 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 11 months ago (2015-01-16 12:46:36 UTC) #6
dcarney
lgtm
5 years, 11 months ago (2015-01-16 12:47:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/828803004/1
5 years, 11 months ago (2015-01-16 12:48:35 UTC) #9
Sven Panne
LGTM, although this is very interesting code, for a certain definition of "interesting"... o_O
5 years, 11 months ago (2015-01-16 12:50:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 13:16:38 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f91e8046fad99365c74ccbb39d42de58398dab57 Cr-Commit-Position: refs/heads/master@{#26103}
5 years, 11 months ago (2015-01-16 13:16:52 UTC) #12
Michael Achenbach
5 years, 11 months ago (2015-01-16 16:49:19 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/856813003/ by machenbach@chromium.org.

The reason for reverting is: Speculative revert to see if win XP recovers. Will
reland if not..

Powered by Google App Engine
This is Rietveld 408576698