Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 828733002: Add DumpAccessibilityTree tests (18 of 20) (Closed)

Created:
5 years, 11 months ago by shreeramk
Modified:
5 years, 11 months ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DumpAccessibilityTree tests (18 of 20) BUG=170590 Committed: https://crrev.com/81fd90fed9651d1e6c8635aabe61e342dc696b33 Cr-Commit-Position: refs/heads/master@{#310074}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -10 lines) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 3 chunks +16 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-disabled.html View 1 chunk +11 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria/aria-disabled-expected-android.txt View 1 1 chunk +1 line, -1 line 0 comments Download
A content/test/data/accessibility/aria/aria-disabled-expected-mac.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria/aria-disabled-expected-win.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
A + content/test/data/accessibility/aria/aria-document.html View 1 chunk +1 line, -1 line 0 comments Download
A content/test/data/accessibility/aria/aria-document-expected-android.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-document-expected-mac.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-document-expected-win.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria/aria-listitem.html View 1 chunk +0 lines, -1 line 0 comments Download
A + content/test/data/accessibility/aria/aria-listitem-expected-android.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
A + content/test/data/accessibility/aria/aria-listitem-expected-mac.txt View 1 1 chunk +1 line, -3 lines 0 comments Download
A + content/test/data/accessibility/aria/aria-listitem-expected-win.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
A content/test/data/accessibility/aria/aria-selected.html View 1 chunk +13 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-selected-expected-android.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-selected-expected-mac.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-selected-expected-win.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
shreeramk
Please review. Thanks!
5 years, 11 months ago (2014-12-29 14:34:35 UTC) #2
shreeramk
On 2014/12/29 14:34:35, shreeramk wrote: > Please review. Thanks! @Dominic: PTAL. Thanks!
5 years, 11 months ago (2015-01-06 02:45:50 UTC) #3
dmazzoni
lgtm
5 years, 11 months ago (2015-01-06 07:01:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/828733002/20001
5 years, 11 months ago (2015-01-06 07:01:52 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-06 08:42:08 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 08:43:11 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/81fd90fed9651d1e6c8635aabe61e342dc696b33
Cr-Commit-Position: refs/heads/master@{#310074}

Powered by Google App Engine
This is Rietveld 408576698